Tech/improvements 2 #10083
Merged
Tech/improvements 2 #10083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
force-pushed
the
tech/improvements-2
branch
from
16e83d8
to
348d09b
Compare
ndelangen
commented
Mar 9, 2020
| const { id, title, href, active } = rest; | ||
| const onClick = useCallback( | ||
| (event: SyntheticEvent) => { | ||
| onClickFromProps(event, rest); |
There was a problem hiding this comment.
It now gets called with 2 arguments, the first is the event, as it was before, the second (new) argument is the object, with the id, href, etc on it.
ndelangen
force-pushed
the
tech/improvements-2
branch
from
348d09b
to
a5e716e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE so all interfaces & types are exported in lib/ui
REMOVE really weird href = object type
ADD ability for Tooltip onClick event access to clicked item + event