-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Update fixtures used for CLI tests #10396
Conversation
These fixtures are used to check that `sb init` is properly initializing SB in the fixture context so SB config (and stories) shouldn't be already in the fixture. Moreover, fixtures were using outdated `config.js` file and a new `main.js` config file is added during initialization causing SB build to fail with: ``` ERR! Error: You have both a "main" and a "config". Please remove the "config" file from your configDir ```
There is no more fixture related to `react_babel_6` so I removed all refs to that in scripts used to run CLI tests
Failing CI checks are related to IE11 and are also failing on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hello, I have this error, but I did not understand how you fixed it, can you explain like in steps with the path and name of the files, please! |
The error occurred because the project was using Storybook 5.3+ but had 5.2- config files. |
I resolved this with one of the steps there, tahnk you very much!!. |
What I did
♻️ Remove SB config and stories from CLI test fixtures:
These fixtures are used to check that
sb init
is properly initializing SB in the fixture context so SB config (and stories) shouldn't be already in the fixture.Moreover, fixtures were using outdated
config.js
file and a newmain.js
config file is added during initialization causing SB build to fail with:ERR! Error: You have both a "main" and a "config". Please remove the "config" file from your configDir
🗑 Remove
react_babel_6
refs in CLI tests:There is no more fixture related to
react_babel_6
so I removed all refs to that in scripts used to run CLI testsHow to test