CHANGE isToolshown logic so it hides toolbar if there's only (hidden) canvas

[ndelangen]

Issue: #10592

What I did

Fixed a bug where the toolbar might be shown with nothing in it.

[hipstersmoothie]

Will this also make storybook navigate to the first non hidden tab?

[shilman]

Not obvious to me how this corresponds to the original issue. Can you provide a test, or a comment on why this logic makes sense?

[ndelangen]

When the viewMode is docs, we only show tabs
When the number of tabs is 1, there's no point in showing them
When we don't show anything, the toolbar should be collapsed

AFAIK this was exactly the issue in #10592

This code makes it so when there's only 1 tab shown in docsmode the toolbar collapses

[shilman]

I didn't repro #10592 but @hipstersmoothie 's issue is that "nothing is rendered". AFAICT this change renders even less than what was there before, so I don't understand how this could solve that.

[hipstersmoothie]

I can set up an example repo if neeed

[shilman]

Best is repro in official-storybook

[matheo]

@ndelangen @shilman I've ran this locally and the only issue I see is that on initial load,
the MDX docs-only page that I select on SET_STORIES shows the toolbar like:

and after navigate another story with Canvas/Docs tab, and going back, it's not shown:

the tabs/reordering seems to work fine with beta.22 :D
now I'd like to know how to set the selectedTab in a similar way as selectedPanel hehe

[matheo]

@ndelangen I've confirmed that one of my issues (#10294)
was caused by moving the docs panel to the left with:

addons.setConfig({
  previewTabs: {
    'storybook/docs/panel': { index: -1 },
  },
});

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[ndelangen]

I'm just gonna close this if those doesn't fix any issues people are having.

[matheo]

@ndelangen this fixes an empty toolbar for docsOnly pages:

the only missing detail is the initial-state, but this does PR the job

[ndelangen]

@matheo would you have some time to make any changes to this PR you deem necessary?

[matheo]

@ndelangen I'm not quite familiar with React's state management to figure out the initial-value fix. For me this PR does an important part of the job tho. I'm +1 to merge this and avoid the empty toolbar div first.