Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix search in production mode #10917

Merged
merged 3 commits into from
Jun 8, 2020
Merged

UI: Fix search in production mode #10917

merged 3 commits into from
Jun 8, 2020

Conversation

ndelangen
Copy link
Member

Issue: #10519

What I did

Picked the important parts of #10539 for next branch

@ndelangen ndelangen added the bug label May 26, 2020
@ndelangen ndelangen requested a review from tmeasday May 26, 2020 07:04
@ndelangen ndelangen self-assigned this May 26, 2020
@ndelangen ndelangen changed the title apply https://github.com/storybookjs/storybook/pull/10539 on next apply #10539 on next May 26, 2020
# Conflicts:
#	lib/core/src/client/preview/loadCsf.ts
@ndelangen ndelangen added this to the 6.0 milestone Jun 4, 2020
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -40,7 +40,7 @@ const loadStories = (
fileExports,
// todo discuss: types infer that this is RequireContext; no checks needed?
// NOTE: turns out `babel-plugin-require-context-hook` doesn't implement this (yet)
typeof req.resolve === 'function' ? req.resolve(filename) : null
typeof req.resolve === 'function' ? req.resolve(filename) : filename
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndelangen what's this line doing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix #10519

@shilman shilman changed the title apply #10539 on next UI: Fix search in production mode Jun 8, 2020
@shilman shilman merged commit 5caae38 into next Jun 8, 2020
@ndelangen ndelangen deleted the fix/10519 branch June 8, 2020 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants