-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript: Update react-docgen-typescript-plugin #11140
Conversation
@mrmckeb This should fix the regression |
Thanks! I'll get another reviewer to take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fast turnaround on this @hipstersmoothie!
When you have time can you take a quick look at the Chromatic tests? I think there was maybe a regression here: https://www.chromatic.com/snapshot?appId=5a375b97f4b14f0020b0cda3&id=5ee338c1bc150a0022389b99 The other two changes look like improvements.
I'm going to approve and merge this, but I think fixing that one is probably a follow-up task.
I’ll look at those tomorrow @shilman |
The first one is actually an improvement. That story seems to be demonstrating that you can filter out props from React (html attrs). For other the two where you think it's better it seems like the plugin is now respecting the |
Nice @hipstersmoothie! I didn't actually dig into the example -- assumed missing props = bug, but you're right. Sorry for the false alarm! |
What I did
react-docgen-typescript-plugin
loads an dummy plugin when typescript is not installedHow to test
If your answer is yes to any of these, please make sure to include it in your PR.