-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert moving index.[ios|android].js. #1201
Conversation
2a98396
to
effa811
Compare
Codecov Report
@@ Coverage Diff @@
## master #1201 +/- ##
==========================================
+ Coverage 13.71% 13.72% +0.01%
==========================================
Files 207 207
Lines 4615 4611 -4
Branches 509 621 +112
==========================================
Hits 633 633
+ Misses 3535 3434 -101
- Partials 447 544 +97
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposal in the spirit of the original DRY change:
mv index.js storybook.js
Both index.android.js
and index.android.js
get:
import StorybookUI from './storybook';
export default StorybookUI;
Tested this for ios
and it works.
effa811
to
782a6e3
Compare
Interesting, it didn't have the bug when I did it that way. I think maybe when I tried to make it |
Issue: See #1200
What I did
Moved
index.js -> index.[ios|android].js
. (It didn't seem possible to make the files importindex.js
, I ran into this problem: facebook/react-native#6282, maybe you aren't allowed to register components from an imported file? IDK).How to test
Follow the steps in #1200, but using
npm link
-ed CLI