Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMPROVE design of addon-events #1249

Merged
merged 4 commits into from
Jun 11, 2017
Merged

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jun 10, 2017

Issue: -addon-events-looked-pretty -rough-

What I did

I improved it by a margin
screen shot 2017-06-10 at 20 04 34

How to test

view cra-storybook

@ndelangen ndelangen added this to the v3.1.4 milestone Jun 10, 2017
@ndelangen ndelangen self-assigned this Jun 10, 2017
@ndelangen ndelangen requested a review from z4o4z June 10, 2017 18:09
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! But instead of the 📡 icon, how about a ⏯ button?

@ndelangen
Copy link
Member Author

📢

@codecov
Copy link

codecov bot commented Jun 11, 2017

Codecov Report

Merging #1249 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1249      +/-   ##
==========================================
- Coverage   13.75%   13.73%   -0.02%     
==========================================
  Files         207      207              
  Lines        4632     4638       +6     
  Branches      512      606      +94     
==========================================
  Hits          637      637              
+ Misses       3544     3487      -57     
- Partials      451      514      +63
Impacted Files Coverage Δ
addons/events/src/components/Panel.js 0% <ø> (ø) ⬆️
addons/events/src/components/Event.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/init_panels.js 25% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.86% <0%> (ø) ⬆️
app/react/src/client/preview/init.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
app/react/src/client/preview/error_display.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/reducer.js 0% <0%> (ø) ⬆️
addons/info/src/components/markdown/code.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/usplit.js 38.7% <0%> (ø) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d167f91...b4bc048. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants