Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(addons/info): Cannot read property 'props' of undefined #1258

Merged
merged 5 commits into from
Jun 12, 2017
Merged

fix(addons/info): Cannot read property 'props' of undefined #1258

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7a95ee2
fix(addons/info): Cannot read property 'props' of undefined
evenchange4 Jun 12, 2017
a7ddf63
add propTypes
evenchange4 Jun 12, 2017
13939bd
update propTypes
evenchange4 Jun 12, 2017
71a48df
isRequired
evenchange4 Jun 12, 2017
106514f
feat(Addon/info): use external links
evenchange4 Jun 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions addons/info/src/components/markdown/text.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ export function A(props) {
const style = {
color: '#3498db',
};
return <a href={this.props.href} style={style}>{props.children}</a>;
return <a href={props.href} style={style}>{props.children}</a>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: add target="_blank" rel="noopener noreferrer"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, I always put external links here, and there is already @storybook/addon-links solution for linking between stories at same site.

}

A.defaultProps = defaultProps;
A.propTypes = propTypes;
A.propTypes = { children: PropTypes.node, href: PropTypes.string.isRequired };