Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info add-on: update z-index of container #1264

Merged
merged 3 commits into from
Jun 15, 2017

Conversation

kohlmannj
Copy link
Contributor

Issue: #1263

What I did

I updated the info addon's fixed-position container to use a z-index of 99999, thereby allowing it to appear above most other content that may appear in the preview iframe.

How to test

With stories that use the Info addon:

  • Verify that the info content appears above all other preview iframe content when clicking on the "Show Info" tab
  • Verify that the blue "X" tab still appears above the info content when the info content is being shown

@codecov
Copy link

codecov bot commented Jun 12, 2017

Codecov Report

Merging #1264 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1264   +/-   ##
=======================================
  Coverage   13.71%   13.71%           
=======================================
  Files         207      207           
  Lines        4646     4646           
  Branches      509      496   -13     
=======================================
  Hits          637      637           
- Misses       3568     3589   +21     
+ Partials      441      420   -21
Impacted Files Coverage Δ
addons/info/src/components/Story.js 0% <ø> (ø) ⬆️
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
...rc/modules/ui/components/left_panel/text_filter.js 33.33% <0%> (ø) ⬆️
app/react/src/client/preview/error_display.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/api/configs/init_api.js 40.47% <0%> (ø) ⬆️
addons/info/src/components/Props.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Object.js 5.81% <0%> (ø) ⬆️
...react-native/src/manager/components/PreviewHelp.js 0% <0%> (ø) ⬆️
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
addons/knobs/src/components/types/Number.js 8.06% <0%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23c3902...0989765. Read the comment docs.

@danielduan
Copy link
Member

I guess if you have a z-index set in your component, it could appear above the info panel.

Info will probably get refactored into its own panel but this will fix the outstanding issue for now.

@shilman shilman added the cleanup Minor cleanup style change that won't show up in release changelog label Jun 13, 2017
@kohlmannj
Copy link
Contributor Author

@danielduan agreed, this is just supposed to be a short-term fix. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants