Addon-docs/Angular: Fix inline rendering setup #14270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
aaa @shilman I just remembered why I didn't add it here. the goal is to keep the 2 dependencies "@angular/elements" and "@webcomponents/custom-elements" optional for the user. So if we import the function to make a test it is necessary to start an angular application with storybook. outside the monorepo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #8153
What I did
Set up Angular
prepareForInlineinside the preset. Users can enable it on by simply settingdocs.inlineStories: trueand we don't need to create another entry point or import in the user's code.NOTE that this is a breaking change for prerelease users, since this PR removes the unnecessary entry point.
How to test