Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Essentials: Update measure/outline addons to support ESM and vite builder #15144

Merged
merged 2 commits into from
Jun 5, 2021
Merged

Essentials: Update measure/outline addons to support ESM and vite builder #15144

merged 2 commits into from
Jun 5, 2021

Conversation

winkerVSbecks
Copy link
Contributor

Issue:

What I did

  • Updated the addons to build for bothm cjs and esm
  • Now works with vite builder

@nx-cloud
Copy link

nx-cloud bot commented Jun 4, 2021 •
edited
Loading

Nx Cloud Report

CI ran the following commands for commit 37acb99. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

shilman
shilman approved these changes Jun 5, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman
Copy link
Member

shilman commented Jun 5, 2021

@winkerVSbecks build is failing due to an unrelated change in web-components-kitchen-sink (cc @gaetanmaisse). merging anyway to keep things moving forward.

@shilman shilman changed the title Update measure and addon outlines to support esm and vite builder Essentials: Update measure/outline addons to support ESM and vite builder Jun 5, 2021
@shilman shilman merged commit 97f0f03 into next Jun 5, 2021
@shilman shilman deleted the addon-measure-outline-esm branch June 5, 2021 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@ndelangen ndelangen Awaiting requested review from ndelangen

Assignees
No one assigned
Labels
addon: essentials feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winkerVSbecks @shilman