-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML: Dynamic source snippets #15748
HTML: Dynamic source snippets #15748
Conversation
Nx Cloud ReportCI ran the following commands for commit be1eea5. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
One quick note, I couldn't seem to get this working locally in the kitchen sink examples. They just weren't showing code previews at all. Unsure if I did something wrong, could definitely use some pointers! |
@pzuraq this is awesome!! 💯 working great for me: what I did: yarn bootstrap --core
cd examples/html-kitchen-sink
yarn storybook |
Hey @pzuraq this is an incredible contribution, thanks a lot for that! 🤩 I've got a couple of remarks: 1 - Could you check and update the snapshots in 2 - Your commit doesn't link to your github user. Seems like your
The issues in the E2E tests don't seem to be related to your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great @pzuraq -- love the tests 🚀
Adds dynamic source to the HTML 'framework' package.
b8b55e9
to
be1eea5
Compare
@shilman ah, I didn't realize I had to run bootstrap again before using the kitchen sink apps! Cool, works perfectly now 😄 @yannbf thanks for pointing those out, I updated the snapshots, and the issue with the commit was my Git settings were off (changed companies recently, and started signing commits but forgot to upload my public PGP key 😱). Everything should be good to go now! |
Great stuff @pzuraq 👏 |
Freakin' amazing! Thank you so much pzuraq! |
Thank you @pzuraq!!! I upgraded to pre-release but I am still getting "No code available" (in fact, the default install shows the same). Is there a setting to get this to work?
|
If I change line 19 in the default install
to
it works, since it returns a string instead of a DOM node / HTMLElement. |
Awesome! 😍 Thanks @pzuraq! Is there a config to make it “prettier”? |
Issue: #12755
Adds dynamic source to the HTML 'framework' package.
What I did
Emits the rendered HTML if the HTML output was a string, otherwise does nothing. Output is also dedented by default. Mostly based on this PR: #15337
How to test