Addon-actions: Omit sending window object thru the channel #16514
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6471
What I did
I detect a react synthetic event, perform a shallow clone, mark the clone with
persist()
and, if the event has aview
property which is an instance ofWindow
, also perform a shallow clone on that object, so that the entire window object is not passed through the channel (which would cause it to be fully cloned every time with the structured clone algorithmHow to test
yarn start
).Everything continues to work, the UI is much more responsive (since it's not cloning the entire window on every action), and you can see that the "Window" entry for

view
is not expandable.