Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Workaround for compodoc on windows machines #17334

Merged
merged 2 commits into from
Jan 29, 2022

Conversation

kroeder
Copy link
Member

@kroeder kroeder commented Jan 26, 2022

path.relative is necessary to workaround a compodoc issue with
absolute paths on windows machines

Issue:

What I did

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

path.relative is necessary to workaround a compodoc issue with
absolute paths on windows machines
@nx-cloud
Copy link

nx-cloud bot commented Jan 26, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit f7da999. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@kroeder kroeder added angular bug patch:yes Bugfix & documentation PR that need to be picked to main branch windows labels Jan 26, 2022
@shilman shilman changed the title fix(app/storybook): workaround for compodoc on windows machines Angular: Workaround for compodoc on windows machines Jan 29, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @kroeder 🙏

@shilman shilman merged commit 2c5f69c into next Jan 29, 2022
@shilman shilman deleted the fix-compodoc-for-windows branch January 29, 2022 06:52
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 29, 2022
shilman added a commit that referenced this pull request Jan 29, 2022
Angular: Workaround for compodoc on windows machines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants