Core: Fix staticDirs path issue on Windows

[justrhysism]

Issue: #17271

What I did

Noticed that the test "supports absolute file paths with custom endpoint" didn't cover the reality for Windows.

The relativeDir provided by getDirectoryFromWorkingDir() resolves all paths to OS separators (e.g. \ on Windows). The result of which would look like C:\\foo\\bar:\\custom-endpoint and not C:\\foo\\bar:/custom-endpoint which the test was covering; so I added a test to cover the actual case.

---

Digging in, the regex split in parseStaticDir didn't account for the actual path, as it was ignoring all cases of :\ to cover the X:\ scenario, which is what resulted in bug #17271.

To work around this, I changed the code to look for the last colon :, and use that to split. However, in case the last colon is actually part of a Windows absolute path (e.g. C:\), needed to check a few conditions:

• Is the path Windows absolute? (We don't care if Unix absolute because it won't have a colon)
• Is the path just a single path (i.e. doesn't contain the : delimiter for static and target dirs.

Once this was determined, the final piece of the puzzle was ensuring the target was converted from \ to /, for which I just split on path.sep and joined on path.posix.sep to ensure a forward-slash /.

---

How to test

• Is this testable with Jest or Chromatic screenshots?
• Does this need a new example in the kitchen sink apps?
• Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

[nx-cloud]

☁️ Nx Cloud Report

CI ran the following commands for commit 6f9c8a5. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 1 target

• nx run-many --target=prepare --all --parallel --max-parallel=15 -- --optimized

---

Sent with 💌 from NxCloud.

[justrhysism]

The failing e2e test doesn't appear to have anything to do with the code I've changed?

[shilman]

@tooppaaa can you please kick the tires on windows? 🙏

[tooppaaa]

Everything looks good on windows ! 🚀

[shilman]

Suggested change

	await expect(parseStaticDir('C:\\foo\\bar:\\custom-endpoint')).resolves.toEqual({
	await expect(parseStaticDir('C:\\foo\\bar:/custom-endpoint')).resolves.toEqual({

shouldn't this be a forward slash since it's a URL?

[justrhysism]

So, the underlying issue is that getDirectoryFromWorkingDir() in useStatics returns this "URL" with backslashes; see arg in the screencap:

I'm sure that parseStaticDir is intended to receive the path as a URL, but the reality is that it might not.

As such, I've left the original test with /custom-endpoint and added \\custom-endpoint to ensure this case is covered.

---

I did briefly consider fixing the underlying issue inside useStatics, however that seemed like a much riskier fix with a much, much broader footprint. To me the safer course of action was to make parseStaticDir more forgiving (not to mention significantly easier for my first contrib).

[shilman]

Thanks for the clarification! 🙏

[shilman]

Thanks so much for the great fix @justrhysism !!! 🙏

[IanVS]

BTW, to run unit tests on windows, you can add the ci:matrix label to the PR. Just in case that's helpful for anyone in the future. Maybe we should trigger on windows too?