-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Wait 100ms before showing spinner and fix story overlaying it #17753
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0266f52. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
@tmeasday this is great!!! Incredibly better. I noticed a regression related to loaders, maybe it's out of scope but I thought of sharing: loadersbug.mp4 |
Just to write down what's in the video:
Playing with Happy to discuss 1&2 but I think we can merge this without fixing them. |
Thinking about things for a bit:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tmeasday! I agree on your points 👍
Issue: #17122
What I did
How to test
For 1. see http://localhost:9011/?path=/story/core-loaders--z-index -- try switching to the other loading story, notice the spinner overlay/hides the z-index story
For 2. see http://localhost:9011/?path=/story/core-rendering--auto-focus
For 3. switch between first two backgrounds stories: http://localhost:9011/?path=/story/addons-backgrounds--story-1