Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Renderer refactor #17982

Merged
merged 39 commits into from
Jun 6, 2022
Merged

Core: Renderer refactor #17982

merged 39 commits into from
Jun 6, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Apr 16, 2022

Issue:

What I did

This PR introduces the concept of a renderer which is the builder-independent pieces to support a view layer, plus the docs preview code (for now)

  • renderToDom (required) - render the result of a render function to the DOM
  • render (optional) - the default CSF3 render function when the user doesn't provide one, e.g. export Story = { args: { ... } }

The renderers are also presets, introduced in telescoping PR #18004, which has now been merged.

How to test

  • CI passes

@nx-cloud
Copy link

nx-cloud bot commented Apr 16, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a71e653. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman changed the base branch from next to future/remove-start-build-storybook April 16, 2022 07:41
@shilman shilman added the maintenance User-facing maintenance tasks label Apr 17, 2022
@shilman shilman mentioned this pull request Apr 21, 2022
1 task
Base automatically changed from future/remove-start-build-storybook to future/base April 26, 2022 08:59
@shilman shilman changed the title Core: Renderer refactor Core: Renderer refactor (1/N) May 4, 2022
@shilman shilman marked this pull request as ready for review May 11, 2022 11:27
@shilman shilman marked this pull request as draft May 11, 2022 11:27
@shilman shilman changed the title Core: Renderer refactor (1/N) Core: Renderer refactor Jun 6, 2022
@shilman shilman marked this pull request as ready for review June 6, 2022 16:17
@shilman shilman merged commit 232d0c0 into future/base Jun 6, 2022
@shilman shilman deleted the future/add-renderers branch June 6, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant