Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Split webpack presets out of frameworks #18018

Merged
merged 36 commits into from
Jun 6, 2022
Merged

Core: Split webpack presets out of frameworks #18018

merged 36 commits into from
Jun 6, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Apr 21, 2022 •
edited
Loading

Issue: N/A

Telescoping PR, builds on #18004

What I did

  • Created webpack presets for html, preact, react, server, vue, vue3, web-components

@storybook/preset-x-webpack are version-independent packages that can be used with builder-webpack4 or webpack5 to create frameworks.

How to test

  • CI passes

@shilman shilman added the maintenance User-facing maintenance tasks label Apr 21, 2022
@nx-cloud
Copy link

nx-cloud bot commented Apr 21, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 484c914. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman changed the base branch from next to future/renderer-presets April 21, 2022 08:48
@shilman shilman changed the title Future/add frameworks Core: Split presets out of frameworks Apr 21, 2022
@shilman shilman changed the title Core: Split presets out of frameworks Core: Split webpack presets out of frameworks Apr 21, 2022
@shilman shilman marked this pull request as ready for review April 27, 2022 01:54
@shilman shilman changed the title Core: Split webpack presets out of frameworks Core: Split webpack presets out of frameworks (3/N) May 4, 2022
@shilman shilman marked this pull request as draft May 4, 2022 11:45
@shilman shilman mentioned this pull request May 4, 2022
Merged
2 tasks
Base automatically changed from future/renderer-presets to future/add-renderers May 11, 2022 11:37
@shilman shilman changed the title Core: Split webpack presets out of frameworks (3/N) Core: Split webpack presets out of frameworks (2/N) May 11, 2022
@shilman shilman mentioned this pull request Jun 6, 2022
Merged
4 tasks
@shilman shilman changed the title Core: Split webpack presets out of frameworks (2/N) Core: Split webpack presets out of frameworks Jun 6, 2022
Base automatically changed from future/add-renderers to future/base June 6, 2022 16:17
@shilman shilman marked this pull request as ready for review June 6, 2022 16:17
@shilman shilman merged commit b96cec6 into future/base Jun 6, 2022
@shilman shilman deleted the future/add-frameworks branch June 6, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shilman