Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Allow builders to be set in presets #18182

Merged
merged 2 commits into from
May 21, 2022
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented May 10, 2022

Issue: N/A

What I did

  • Load presets twice so that presets can define builders, which is necessary for framework support
  • Clean up manager/preview builder detection code

Self-merging @tmeasday @ndelangen and we can optimize in a second pass later

How to test

  • CI passes

@nx-cloud
Copy link

nx-cloud bot commented May 10, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 45ee146. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman changed the title Allow builders to be set in presets Core: Allow builders to be set in presets May 14, 2022
@shilman shilman added maintenance User-facing maintenance tasks core labels May 14, 2022
@shilman shilman mentioned this pull request May 14, 2022
3 tasks
@shilman shilman marked this pull request as ready for review May 21, 2022 18:08
@shilman shilman merged commit 8fcdc65 into future/base May 21, 2022
@shilman shilman deleted the future/builder-presets branch May 21, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant