Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix sidebar a11y by moving aria-expanded attribute to button #18354

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

Daraphista
Copy link
Contributor

Issue: #18346

What I did

Moved the aria-expanded attribute from the RootNode to CollapseButton
image

How to test

You should see the changes reflected in the DOM

@nx-cloud
Copy link

nx-cloud bot commented May 29, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0e2988c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman changed the title fix(sidebar): move aria-expanded attribute to button UI: Fix sidebar a11y by moving aria-expanded attribute to button May 29, 2022
Copy link

@ColinRosati ColinRosati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@micahgodbolt
Copy link
Contributor

Any movement on this PR? Can we get tests passing?

Copy link
Contributor

@kylegach kylegach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this important fix, @Daraphista! And congratulations on a great first contribution! 🥳

The failing checks are unrelated to this work, so I'll merge it now.

@kylegach kylegach merged commit 8519d51 into storybookjs:next Jun 28, 2022
@kylegach kylegach added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jun 28, 2022
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 26, 2022
shilman pushed a commit that referenced this pull request Jul 26, 2022
UI: Fix sidebar a11y by moving aria-expanded attribute to button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants