-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Handle v3 index in composition #18498
Core: Handle v3 index in composition #18498
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b6ce456. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
@tmeasday this one is not building. maybe i resolved merge conflicts incorrectly? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little fuzzy on the TypeScript changes for Module
. @ndelangen can you please take a look also?
@shilman with the changes to using stricter typescript rules, the tests weren't happy with the looseness of the |
What I did
refs
code a little bit (it was confusing that it was calling different thingsstories
in different places).How to test
Compose a 6.x Storybook into one of the example apps.