Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Switch Meta block to receive all module exports #18514

Merged

Conversation

tmeasday
Copy link
Member

What I did

Update Meta doc block syntax:

import * as FooStories from './foo.stories';

<Meta of={FooStories} />

<Story of={FooStories.FirstStory} />

Use the above to implement ComponentStories for Docs2 👍 (not yet done in external docs)

How to test

Run react-ts, external-docs

@nx-cloud
Copy link

nx-cloud bot commented Jun 20, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3dae5e2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@tmeasday tmeasday changed the base branch from next to future/docs2-core June 20, 2022 06:44
@tmeasday tmeasday requested a review from shilman June 20, 2022 06:44
@shilman shilman changed the title Switch meta to receive all exports Addon-docs: Switch Meta block to receive all exports Jun 20, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome @tmeasday -- really great stuff 💯

addons/docs/src/blocks/DocsContainer.tsx Outdated Show resolved Hide resolved
@shilman shilman changed the title Addon-docs: Switch Meta block to receive all exports Addon-docs: Switch Meta block to receive all module exports Jun 20, 2022
@shilman shilman merged commit f33375b into future/docs2-core Jun 20, 2022
@shilman shilman deleted the tom/sb-416-switch-meta-to-receive-all-exports branch June 20, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants