-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vite: Add builder-vite, react-vite, and vue3-vite #19007
Conversation
They're copied mostly straight, as-is from their old versions. Adjustments will be made in subsequent commits.
These were all implicit dependencies before, which caused problems for pnpm
They need to be accessible from dist, as well
It's causing the cjs file to always be chosen, which breaks in the browser.
It seems to have broken, maybe after 631795b
Not working yet
I traced down the error to the vue3 renderer. It was trying to pass an argument to In fact, if you look at the circleci |
# Conflicts: # .circleci/config.yml
I'm running the e2e-sandbox tests locally, and it's not crashing. All I can see is a few firefox specs failing, but that doesn't seem like what's happening in CI. Another thing I've noticed, when I first open up Edit: maybe the firefox failures are what's happening in CI after all: https://app.circleci.com/pipelines/github/storybookjs/storybook/28590/workflows/a66fc97a-f506-46fe-87bd-5cdf91ede154/jobs/405073/artifacts What seems to be happening in the failing tests is that the navigation to the intended story is not happening, perhaps because the navigation happens too soon, before the page is fully ready, and it stays on the introduction docs page. |
This reverts commit c64c27f.
@IanVS I updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hallelujah!
Issue:
Branched from #19002
What I did
builder-vite
to monoreporeact-vite
frameworkvue3-vite
frameworkpreviewEntries
preset support for parity withbuilder-webpack5
How to test