-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added some basic interactions stories #19153
Conversation
Regarding styling:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ndelangen WDYT about something slightly simpler, ie importing CSS in every "form" file. One thing SB guarantees in our docs is you can import CSS: import './some/path/to/form.css`; (I'm not sure what the path will be, but does that make sense?) |
Move account form stories to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo one clarification
and a (crappy) React implemenation of a form
Posting for feedback on the stories and general approach:
<style>
a good idea?Todo
NOTE
There is some jankiness in the waitFor stories that highlights problems fixed by #19145
How to test
Should be tested by the CI