Enforce @ts-expect-error via eslint #19198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-734-add-eslint-rule-to-enforce-ts-expect
JReinhold
added
cleanup
JReinhold
removed
dependencies
cleanup
JReinhold
commented
Sep 15, 2022
Comment on lines
+1
to
2
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-nocheck |
There was a problem hiding this comment.
looks like ts-nocheck is actually valid here because of the decorators, so I've allowed it.
JReinhold
commented
Sep 15, 2022
| @@ -134,7 +133,7 @@ const starter: StarterFunction = async function* starterGeneratorFn({ | |||
| router.use(webpackHotMiddleware(compiler as any)); | |||
|
|
|||
| const stats = await new Promise<Stats>((ready, stop) => { | |||
| compilation.waitUntilValid(ready as any); | |||
| compilation?.waitUntilValid(ready as any); | |||
There was a problem hiding this comment.
This changes the behavior a little since the original would throw if compilation was undefined while this fails silently. But since compilation is being defined above I think that's okay.
JReinhold
commented
Sep 15, 2022
JReinhold
commented
Sep 15, 2022
| @@ -1,7 +1,8 @@ | |||
| { | |||
| "extends": "../../tsconfig.json", | |||
| "compilerOptions": { | |||
| "strict": true | |||
| "strict": true, | |||
| "skipLibCheck": true | |||
There was a problem hiding this comment.
case-sensitive-paths-webpack-plugin has transitive types issues with webpack5 which we want to ignore because we can't do anything about it. Reading the issues in the repo makes it seem like there might actually be some issues with it and webpack5.
kylemh
approved these changes
Sep 18, 2022
…nt-rule-to-enforce-ts-expect
|
The Vite sandbox failures here are not related to this PR, FWIW. |
shilman
deleted the
jeppe/sb-734-add-eslint-rule-to-enforce-ts-expect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR continues work from #19122 and #19168 and changes the ESLint rule
@typescript-eslint/ban-ts-commentfromwarntoerrorto reduce the number of@ts-ignores in the future.To achieve this, a few TypeScript errors had to be fixed all over the code base. Some where missing types that got added or ignored while other places I fixed the actual errors that TypeScript reported.
How to test
./bootstrap.sh --prepsuccessfully../bootstrap.sh --buildsuccessfully.cd code && yarn lint:jssuccessfully.