-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make the button component accept a label prop, (not children) (used for sandboxes and renderAssets in cli) #19461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
changed the title
make the vue button accept a children prop, consistently
make the button component accept a label prop, (not children) for button components used for sandboxes and renderAssets in cli
Oct 12, 2022
ndelangen
changed the title
make the button component accept a label prop, (not children) for button components used for sandboxes and renderAssets in cli
make the button component accept a label prop, (not children) (used for sandboxes and renderAssets in cli)
Oct 12, 2022
…o use the label prop
|
allright, i think i got it!, finally |
tmeasday
reviewed
Oct 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the pending changes in chromatic on the vue sandboxes
the pending changes are actually wrong, this should fix that.
I made it so we consistently use the
label
prop to insert text in the button, rather than achildren
prop.The idea behind this is that this is accurate enough and renderer agnostic.