Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small check task fixes #19643

Merged
merged 1 commit into from
Oct 27, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 14 additions & 16 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,22 +75,6 @@ commands:
fi

jobs:
check:
executor:
class: xlarge
name: sb_node_16_classic
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
- restore_cache:
name: Restore Yarn cache
keys:
- build-yarn-2-cache-v4--{{ checksum "code/yarn.lock" }}--{{ checksum "scripts/yarn.lock" }}
- run:
name: Check
command: |
yarn task --task check --start-from=auto --no-link --debug
git diff --exit-code
build:
executor:
class: xlarge
Expand Down Expand Up @@ -237,6 +221,20 @@ jobs:
command: |
cd code
yarn lint
check:
executor:
class: xlarge
name: sb_node_16_classic
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
- attach_workspace:
at: .
- run:
name: Check
command: |
yarn task --task check --start-from=auto --no-link --debug
git diff --exit-code
script-unit-tests:
executor: sb_node_16_browsers
steps:
Expand Down
3 changes: 2 additions & 1 deletion scripts/tasks/check.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ export const check: Task = {
async ready() {
return false;
},
async run({ codeDir }, { dryRun, debug }) {
async run({ codeDir }, { dryRun, debug, link }) {
if (link) throw new Error('Cannot check when linked, please run with `--no-link`');
return exec(
command,
{ cwd: codeDir },
Expand Down