Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable keyboard shortcuts during (docs) play functions and add tests #19668

Merged
merged 6 commits into from
Oct 31, 2022
Merged

Disable keyboard shortcuts during (docs) play functions and add tests #19668

merged 6 commits into from
Oct 31, 2022

Commits on Oct 28, 2022

  1. Don't emit key strokes if *any* play function is in progress

    @tmeasday
    tmeasday committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    0d1ce62 View commit details
    Browse the repository at this point in the history

  2. Add stories to check shortcuts aren't called from play

    @tmeasday
    tmeasday committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    6e2b837 View commit details
    Browse the repository at this point in the history

  3. Add E2E test for keyboard shortcut behaviour

    @tmeasday
    tmeasday committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    ebc28fc View commit details
    Browse the repository at this point in the history

  4. Update code/lib/preview-web/src/PreviewWeb.tsx

    @tmeasday
    tmeasday authored Oct 28, 2022
    Configuration menu
    Copy the full SHA
    e50db9f View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2022

  1. Remove unnecessary delay

    @tmeasday
    tmeasday committed Oct 29, 2022
    Configuration menu
    Copy the full SHA
    ce99cfe View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. Make button selector more specific

    @tmeasday
    tmeasday committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    59d2b28 View commit details
    Browse the repository at this point in the history