Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more peerDependencies issues #20120

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Fix more peerDependencies issues #20120

merged 2 commits into from
Dec 7, 2022

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Dec 7, 2022

We found that:

 WARN  Issues with peer dependencies found
.
└─┬ @storybook/react-webpack5 7.0.0-alpha.60
  └─┬ @storybook/preset-react-webpack 7.0.0-alpha.60
    ├── ✕ missing peer jest-specific-snapshot@^7.0.0
    └── ✕ missing peer require-from-string@^2.0.2
Peer dependencies that should be installed:
  jest-specific-snapshot@^7.0.0  require-from-string@^2.0.2     

..happens when installing storybook 7.0-alpha.60, in a webpack project.

What i did

I removed these dependencies, because according to depcheck they are not needed at all:

(tech/peer-dep-attempt)⚡ % npx depcheck                                                ~/Projects/Storybook/core/code/presets/react-webpack
Unused dependencies
* @babel/preset-flow
* @storybook/react
Unused devDependencies
* @types/util-deprecate
* jest-specific-snapshot

@ndelangen ndelangen requested a review from shilman December 7, 2022 09:23
@ndelangen ndelangen self-assigned this Dec 7, 2022
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Dec 7, 2022
@ndelangen ndelangen merged commit b43cd8a into next Dec 7, 2022
@ndelangen ndelangen deleted the fix/more-peerdeps branch December 7, 2022 09:54
@ndelangen
Copy link
Member Author

Thank you @valentinpalkovic for quick review ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants