Vite: Prepare for Vite 4 #20131
Closed
Vite: Prepare for Vite 4 #20131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all frameworks use imports from "vite" directly.
yannbf
reviewed
Dec 7, 2022
| @@ -56,8 +56,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "@types/node": "^16.0.0", | |||
| "typescript": "^4.9.3", | |||
| "vite": "^3.1.3" | |||
There was a problem hiding this comment.
can you elaborate why html, web-components and sveltekit are dropping Vite as a dependency, while the others are not?
There was a problem hiding this comment.
I think it's because some of the packages import directly from Vite (mostly just the types) while the others don't.
JReinhold
approved these changes
Dec 7, 2022
|
I've rolled this PR into #20139, there's not really a need to keep them separate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Vite is about to release version 4 in a few days, but our packages depend strictly on version 3.
What I did
dependencyrange to encompass version 3 and 4.devDependencyto the latest version 4 beta.How to test
Ideally, we would also update our sandboxes to use
yarn create vite@betaor something like that. Butcreate-vitehas not yet been updated to use the beta. I'm discussing with the vite team if that can be done prior to the final release.So, I think this isn't a great test that vite 4 will work correctly, until we can update those sandboxes, but we need to make this change anyway to avoid problems once vite 4 is released.