Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech: improve global types #20184

Merged
merged 40 commits into from
Dec 20, 2022
Merged

Tech: improve global types #20184

merged 40 commits into from
Dec 20, 2022

Commits on Dec 1, 2022

  1. some fixes, need more work

    @ndelangen
    ndelangen committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    1925182 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2022

  1. try to make builder-manager prefer mjs, for tree-shaking

    @ndelangen
    ndelangen committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    f8d5551 View commit details
    Browse the repository at this point in the history

  2. trying to debug the vite-builder problem 

    The issue is vite doesn't pass certain files throw the transform plugin, this causes the globalization to not be complete, causing multiple version of the same module, which is designed to be a singleton.

me and Ian looked at it, we need to investigate further.

Co-authored-by: Ian VanSchooten <ian.vanschooten@gmail.com>
    @ndelangen @IanVS
    ndelangen and IanVS committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    b6f3d29 View commit details
    Browse the repository at this point in the history

  3. unsupported temp api that's not supposed to be there, doesn't need types

    @ndelangen
    ndelangen committed Dec 2, 2022
    Configuration menu
    Copy the full SHA
    db36af9 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Merge branch 'next' into fix/storystorev6-vite

    @ndelangen
    ndelangen committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    18d3b8d View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2022

  1. strong typing for globals, fix issues resulting from strong global ty… 

    …pes, enforce clientApi singleton via global
    @ndelangen
    ndelangen committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    501dce1 View commit details
    Browse the repository at this point in the history

  2. add "dom.iterable" and use global as window

    @ndelangen
    ndelangen committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    42bf76e View commit details
    Browse the repository at this point in the history

  3. fix all the global typings

    @ndelangen
    ndelangen committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    3659bab View commit details
    Browse the repository at this point in the history

  4. fix start test

    @ndelangen
    ndelangen committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    e5b6648 View commit details
    Browse the repository at this point in the history

  5. fixing typings issues

    @ndelangen
    ndelangen committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    f526092 View commit details
    Browse the repository at this point in the history

  6. fixing tests

    @ndelangen
    ndelangen committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    a94e7e8 View commit details
    Browse the repository at this point in the history

  7. fixes

    @ndelangen
    ndelangen committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    5be6d25 View commit details
    Browse the repository at this point in the history

  8. add new storybook scoped package to verdaccio config

    @ndelangen
    ndelangen committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    141dec1 View commit details
    Browse the repository at this point in the history

  9. fix references to global in template dirs

    @ndelangen
    ndelangen committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    3342776 View commit details
    Browse the repository at this point in the history

  10. fixes

    @ndelangen
    ndelangen committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    43aca90 View commit details
    Browse the repository at this point in the history

  11. cleanup

    @ndelangen
    ndelangen committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    d9f736a View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. Merge branch 'next' into norbert/sb-1063-vite-in-dev-mode-with-storys… 

    …torev6
    @ndelangen
    ndelangen committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    5653ec8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fix/storystorev6-vite' into norbert/sb-1063-vite-in-dev… 

    …-mode-with-storystorev6
    @ndelangen
    ndelangen committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    3eb16e7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'next' into norbert/sb-1063-vite-in-dev-mode-with-storys… 

    …torev6
    @ndelangen
    ndelangen committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    556e9e2 View commit details
    Browse the repository at this point in the history

  4. simplify globals

    @ndelangen
    ndelangen committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    b041209 View commit details
    Browse the repository at this point in the history

  5. fix

    @ndelangen
    ndelangen committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    0761c15 View commit details
    Browse the repository at this point in the history

  6. fix

    @ndelangen
    ndelangen committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    c1a62a2 View commit details
    Browse the repository at this point in the history

  7. ensure singleton via global

    @ndelangen
    ndelangen committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    1263ac8 View commit details
    Browse the repository at this point in the history

  8. reset the global every time, to get a new version

    @ndelangen
    ndelangen committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    a7c357a View commit details
    Browse the repository at this point in the history

  9. Merge branch 'norbert/sb-1063-vite-in-dev-mode-with-storystorev6-clea… 

    …ned' into norbert/sb-1063-vite-in-dev-mode-with-storystorev6
    @ndelangen
    ndelangen committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    b052066 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. remove the window as global definition

    @ndelangen
    ndelangen committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    b0977b8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'next' into norbert/sb-1063-vite-in-dev-mode-with-storys… 

    …torev6
    @ndelangen
    ndelangen committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    fe9b5d6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'next' into norbert/sb-1063-vite-in-dev-mode-with-storys… 

    …torev6-cleaned
    @ndelangen
    ndelangen committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    91fe4d8 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'next' into norbert/sb-1063-vite-in-dev-mode-with-storys… 

    …torev6
    @ndelangen
    ndelangen committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    6a578c8 View commit details
    Browse the repository at this point in the history

  5. fix

    @ndelangen
    ndelangen committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    19f3ceb View commit details
    Browse the repository at this point in the history

  6. Merge branch 'norbert/sb-1063-vite-in-dev-mode-with-storystorev6-clea… 

    …ned' into norbert/sb-1063-vite-in-dev-mode-with-storystorev6
    @ndelangen
    ndelangen committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    adb0d25 View commit details
    Browse the repository at this point in the history

  7. cleanup

    @ndelangen
    ndelangen committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    4f3b666 View commit details
    Browse the repository at this point in the history

  8. use feature detection

    @ndelangen
    ndelangen committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    a088aa4 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'next' into norbert/sb-1063-vite-in-dev-mode-with-storys… 

    …torev6
    @ndelangen
    ndelangen committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    a033d29 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. Merge branch 'next' into norbert/sb-1063-vite-in-dev-mode-with-storys… 

    …torev6
    @ndelangen
    ndelangen committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    d7fb0c3 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Merge branch 'next' into norbert/sb-1063-vite-in-dev-mode-with-storys… 

    …torev6
    @ndelangen
    ndelangen committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    9da5823 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'next' into norbert/sb-1063-vite-in-dev-mode-with-storys… 

    …torev6
    @ndelangen
    ndelangen committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    7c2ccbb View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Merge branch 'next' into norbert/sb-1063-vite-in-dev-mode-with-storys… 

    …torev6
    @ndelangen
    ndelangen committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    88f5931 View commit details
    Browse the repository at this point in the history

  2. Restore code/lib/builder-webpack5/templates/virtualModuleModernEntry.… 

    …js.handlebars
    @ndelangen
    ndelangen authored Dec 20, 2022
    Configuration menu
    Copy the full SHA
    fc357d7 View commit details
    Browse the repository at this point in the history

  3. change to use @storybook/global in modern entry

    @ndelangen
    ndelangen committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    bb2e680 View commit details
    Browse the repository at this point in the history