fix: Wrap vite-plugin-external in custom plugin and fix issues #20770
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #20643
Alternate solution for: #20698
What I did
HMR was broken by
vite-plugin-externals
due to returning the entire config from the config hook instead of the partial config as written in the vite api docs: https://vitejs.dev/guide/api-plugin.html#vite-specific-hooks.Recreates the same fix as in crcong/vite-plugin-externals#27 by wrapping the plugin in a custom plugin and overriding the result of the config hook.
How to test
yarn task --task sandbox --start-from auto --template react-vite/default-ts
@storybook/builder-vite
,yarn build --watch builder-vite
fromcode/
directoryChecklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]