Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps: Upgrade fs-extra to 11.1.0 #20772

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Deps: Upgrade fs-extra to 11.1.0 #20772

merged 2 commits into from
Jan 25, 2023

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Jan 24, 2023

Issue: N/A

What I did

While investigating the performance of some vite plugins, I found that our internal version was taking much longer to run ensureDir from fs-extra than the same call in an external plugin (~40 times slower). After updating fs-extra, the performance matched up again. It seems like the recent versions of fs-extra are able to offload more work to native node, and since we are now node 16+, we can take advantage of that.

How to test

I think we should be good-to-go as long as CI passes, but it would be interesting to see if this has any impact on our performance benchmarks as well.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@ndelangen ndelangen self-requested a review January 25, 2023 12:22
@ndelangen ndelangen self-assigned this Jan 25, 2023
@ndelangen ndelangen merged commit 12676d7 into next Jan 25, 2023
@ndelangen ndelangen deleted the update-fs-extra branch January 25, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants