Deps: Upgrade fs-extra to 11.1.0 #20772
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
While investigating the performance of some vite plugins, I found that our internal version was taking much longer to run
ensureDir
from fs-extra than the same call in an external plugin (~40 times slower). After updating fs-extra, the performance matched up again. It seems like the recent versions of fs-extra are able to offload more work to native node, and since we are now node 16+, we can take advantage of that.How to test
I think we should be good-to-go as long as CI passes, but it would be interesting to see if this has any impact on our performance benchmarks as well.
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]