Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Re-enable vue-vite in new-frameworks automigration #20970

Merged
merged 2 commits into from
Feb 13, 2023
Merged

CLI: Re-enable vue-vite in new-frameworks automigration #20970

merged 2 commits into from
Feb 13, 2023

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Feb 6, 2023

Closes #

What I did

I re-enabled @storybook/vue-vite in the CLI.

How to test

I'm not sure why this was disabled in #19016, and I'm not sure how to test it. @yannbf maybe you can check if the problem that made you disable it to start with is fixed?

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@IanVS IanVS added maintenance User-facing maintenance tasks vue builder-vite labels Feb 6, 2023
@IanVS IanVS requested a review from yannbf February 6, 2023 22:47
@benmccann benmccann mentioned this pull request Feb 7, 2023
Closed
5 tasks
@IanVS IanVS added the ci:daily Run the CI jobs that normally run in the daily job. label Feb 9, 2023
yannbf
yannbf approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @IanVS !!!

@yannbf yannbf changed the title CLI: Re-enable vue-vite CLI: Re-enable vue-vite in new-frameworks automigration Feb 13, 2023
@yannbf yannbf merged commit 85e2325 into next Feb 13, 2023
@yannbf yannbf deleted the vite/enable-vue2 branch February 13, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

Assignees
No one assigned
Labels
builder-vite ci:daily Run the CI jobs that normally run in the daily job. maintenance User-facing maintenance tasks vue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IanVS @yannbf