Fix to css Zoom not working in safari #21069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
requested changes
Feb 13, 2023
|
Thank you for your first PR to storybook ❤️ much appreciated, I've left a review requesting some changes, but they are pretty small ones, I think. Let me know if you need any assistance, should be good to merge afterwards. |
ndelangen
reviewed
Feb 14, 2023
Co-authored-by: Norbert de Langen <ndelangen@me.com>
ndelangen
approved these changes
Feb 14, 2023
|
Great! looking forward to your next PR @FlynnFc ! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20888
What I did
Implemented a test for safari. Excludes Chrome, Edge, and all Android browsers.
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["bug","ui", "other"]