Vite: Fix storysource addon support #21096
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20421
Self-merging @tmeasday @joshwooding
What I did
This PR:
There's a bit of history behind this PR. Once upon a time,
addon-docs
andaddon-storysource
both depended on a library calledsource-loader
to load & display raw story source.addon-docs
to a new library calledcsf-plugin
here: Addon-docs: Replace source-loader with csf-plugin #19680csf-plugin
support for Vite and removedsource-loader
here: Vite: Fix static source handling for addon-docs #20147csf-plugin
and updatedaddon-docs
in a way that brokeaddon-storysource
Csf-plugin: Move source to docs.source.originalSource #20665source-loader
/storysource
to get things working in webpack, e.g. Source-loader: Fix export default variable references #20688addon-storysource
andaddon-docs
are completely separated in both vite & webpack.The plan is to:
storysource
that shares code withaddon-docs
storysource/source-loader
, and sunset them in 8.0How to test
yarn task --task sandbox --start-from auto --template react-vite/default-ts --addon storysource
Button
stories and view theStory
tab in the addons panelChecklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]