Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Remove warning when browsing away in React #21214

Merged
merged 3 commits into from
Mar 1, 2023

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Feb 23, 2023

Closes #20731

What I did

Put the cleanup() in a timeout, as advised on the react issue.

Added a story so we can check teardown is still working (only react right now)

How to test

  1. Open a docs page
  2. Browse away
  3. Check it doesn't log warning
  4. Browse away from teardown story in docs + story mode, check it logs 'unmounted'.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove React warning when unmounting a docs page
2 participants