Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD integration artefacts store step to circle.yml #2182

Merged
merged 1 commit into from
Oct 30, 2017

Conversation

ndelangen
Copy link
Member

Issue: -if the integration step failed on CI, locally passes, it's hard to debug-

What I did

Added a step to the integration task to store screenshots as artefacts

How to test

Run the CI
Check if CI stored images

@ndelangen ndelangen self-assigned this Oct 30, 2017
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Oct 30, 2017
@codecov
Copy link

codecov bot commented Oct 30, 2017

Codecov Report

Merging #2182 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2182   +/-   ##
=======================================
  Coverage   21.43%   21.43%           
=======================================
  Files         263      263           
  Lines        5803     5803           
  Branches      694      697    +3     
=======================================
  Hits         1244     1244           
+ Misses       4039     4023   -16     
- Partials      520      536   +16
Impacted Files Coverage Δ
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
app/vue/src/server/utils.js 0% <0%> (-53.58%) ⬇️
addons/knobs/src/components/types/Number.js 8.06% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/left_panel/header.js 29.62% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_keyevents.js 33.33% <0%> (ø) ⬆️
addons/knobs/src/components/types/Object.js 5.81% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_routing.js 28.04% <0%> (ø) ⬆️
...s/left_panel/stories_tree/tree_decorators_utils.js 45.23% <0%> (ø) ⬆️
addons/storyshots/src/storybook-channel-mock.js 0% <0%> (ø) ⬆️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef7869d...e280308. Read the comment docs.

@ndelangen
Copy link
Member Author

screen shot 2017-10-30 at 08 37 22

OK, so what I was afraid for when introducing this happens:
font-rendering on the different platform is different, and this is affecting causes false negatives:

cra-kitchen-sink-diff

Does not block this PR, as this makes it visible to us, but something that must be addressed for longtime usage of screenshots as regression detection.

@Hypnosphi
Copy link
Member

Hypnosphi commented Oct 30, 2017

We should probably use something like saucelabs to collect images on linux machines
Another option is to run a local docker with the same image we use on CI

@Hypnosphi Hypnosphi merged commit 25583c9 into master Oct 30, 2017
@Hypnosphi Hypnosphi deleted the ndelangen/add-integration-artifacts branch October 30, 2017 14:48
@ndelangen
Copy link
Member Author

Another option is to run a local docker with the same image we use on CI

interesting thought!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants