Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vue3): allow to have multiple Vue 3 setup() #22208

Closed
wants to merge 1 commit into from

Conversation

gierschv
Copy link

@gierschv gierschv commented Apr 21, 2023

What I did

I'm using storybook-vue3-router which uses the vue3 renderer setup call, and overrides my call to setup() that I use to setup pinia.

This PR allows to have multiple setup() functions defined and called during the Vue 3 app setup.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@chakAs3
Copy link
Contributor

chakAs3 commented Apr 22, 2023

Hi @gierschv thank you for your contribution and your PR, However there is already a PR #22170 addressing this feature.

@chakAs3 chakAs3 self-assigned this Apr 22, 2023
@chakAs3 chakAs3 closed this Apr 29, 2023
@gierschv gierschv deleted the fix/vue3 branch May 16, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants