Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-textarea-autosize to 5.1.0 #2233

Merged
merged 4 commits into from
Nov 6, 2017

Conversation

Hypnosphi
Copy link
Member

Issue: #2154

@@ -149,7 +149,7 @@ export default class Item extends Component {
</button>
<Textarea
id={`addon-event-${name}`}
ref={ref => {
inputRef={ref => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need all those refs? I can't find any usages of them

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove em, if there are no references 👍

@codecov
Copy link

codecov bot commented Nov 5, 2017

Codecov Report

Merging #2233 into master will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2233      +/-   ##
=========================================
+ Coverage   22.16%   22.2%   +0.03%     
=========================================
  Files         268     268              
  Lines        5875    5869       -6     
  Branches      707     709       +2     
=========================================
+ Hits         1302    1303       +1     
- Misses       4024    4050      +26     
+ Partials      549     516      -33
Impacted Files Coverage Δ
addons/events/src/components/Event.js 0% <ø> (ø) ⬆️
addons/knobs/src/components/types/Object.js 5.88% <ø> (+0.06%) ⬆️
addons/knobs/src/components/types/Array.js 91.66% <100%> (+7.05%) ⬆️
addons/knobs/src/components/types/Text.js 66.66% <33.33%> (+16.66%) ⬆️
app/vue/src/server/utils.js 0% <0%> (-53.58%) ⬇️
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/error_display.js 0% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
lib/components/src/navigation/menu_link.js 0% <0%> (ø) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c14f67...f71cd23. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Nov 6, 2017

Codecov Report

Merging #2233 into master will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2233      +/-   ##
=========================================
+ Coverage   22.16%   22.2%   +0.03%     
=========================================
  Files         268     268              
  Lines        5878    5872       -6     
  Branches      711     712       +1     
=========================================
+ Hits         1303    1304       +1     
+ Misses       4033    4006      -27     
- Partials      542     562      +20
Impacted Files Coverage Δ
addons/events/src/components/Event.js 0% <ø> (ø) ⬆️
addons/knobs/src/components/types/Object.js 5.88% <ø> (+0.06%) ⬆️
addons/knobs/src/components/types/Array.js 91.66% <100%> (+7.05%) ⬆️
addons/knobs/src/components/types/Text.js 66.66% <33.33%> (+16.66%) ⬆️
app/vue/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/vue/src/server/babel_config.js 0% <0%> (-77.42%) ⬇️
app/vue/src/server/utils.js 0% <0%> (-53.58%) ⬇️
lib/ui/src/modules/ui/configs/handle_routing.js 28.04% <0%> (ø) ⬆️
addons/storyshots/src/require_context.js 0% <0%> (ø) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1e1105...aae3d98. Read the comment docs.

@Hypnosphi Hypnosphi merged commit 5d01042 into master Nov 6, 2017
@Hypnosphi Hypnosphi deleted the update-react-textarea-autosize branch November 6, 2017 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants