Core: Fix useStoryPrepared
hook failing with undefined
data
#22631
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
What I did
api.getData
returns undefined sometimes. which is used by isPrepared, the inner logic of useStoryPrepared hook.however, isPrepared hook access to 'type' att without any check.
so I added an exception for this. Now hooks works as expected.
How to test
import { useStoryPrepared } from '@storybook/manager-api
it
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]
🦋 Canary release
This pull request has been released at the npm dist tag
pr-22631
. Install it by pinning all your Storybook dependencies to that tag.More information
7.1.1-pr-22631-1689802540-351503cb.0
@storybook/cli@pr-22631
patch-1
351503cb
1689802540
)To request a new release of this PR ping the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=22631