Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove noise in CI tests #2288

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Remove noise in CI tests #2288

merged 1 commit into from
Nov 13, 2017

Conversation

Hypnosphi
Copy link
Member

Issue: CI unit tests on release/3.3 have a lot of Failed to collect coverage noise. This PR removes it by ignoring CLI snapshots and fixtures

@@ -1,8 +0,0 @@
// https://github.com/michael-ciniawsky/postcss-load-config
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, those 2 files kept producing noise even after adding an ignore pattern

@Hypnosphi Hypnosphi added cleanup Minor cleanup style change that won't show up in release changelog maintenance User-facing maintenance tasks labels Nov 11, 2017
@codecov
Copy link

codecov bot commented Nov 11, 2017

Codecov Report

Merging #2288 into release/3.3 will increase coverage by 0.86%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release/3.3    #2288      +/-   ##
===============================================
+ Coverage        22.61%   23.47%   +0.86%     
===============================================
  Files              346      311      -35     
  Lines             6787     6538     -249     
  Branches           896      814      -82     
===============================================
  Hits              1535     1535              
+ Misses            4564     4404     -160     
+ Partials           688      599      -89
Impacted Files Coverage Δ
app/react/src/server/utils.js 0% <0%> (-53.58%) ⬇️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Boolean.js 11.62% <0%> (ø) ⬆️
...es__/update-addon-info/update-addon-info.output.js 0% <0%> (ø) ⬆️
...res__/update-addon-info/update-addon-info.input.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/element_check.js 41.17% <0%> (ø) ⬆️
addons/storyshots/src/require_context.js 45.58% <0%> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
addons/info/src/components/types/InstanceOf.js 16.66% <0%> (ø) ⬆️
addons/actions/src/util.js 18.91% <0%> (ø) ⬆️
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c8b35a...cd7236e. Read the comment docs.

@Hypnosphi Hypnosphi merged commit 8d92d0c into release/3.3 Nov 13, 2017
@Hypnosphi Hypnosphi deleted the remove-coverage-noise branch November 13, 2017 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants