Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addon-a11y to monorepo #2292

Merged
merged 30 commits into from
Nov 13, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
2a434dd
Initial commit
Oct 2, 2016
12d989e
Fix wrong import in manager.js
Oct 2, 2016
eb76e63
Remove unused preview.js file
Oct 2, 2016
0d67ae2
Correct main entry
Oct 2, 2016
fae8834
Export shared variables in entry point
Oct 4, 2016
0266c97
Create more example stories (#1)
jbovenschen Oct 4, 2016
17acba5
Bump version to 0.0.4
Nov 3, 2016
980468b
Update to use Storybook v3. Closes #7
jrwebdev May 29, 2017
c2aacec
Prepare for release
ndelangen Jun 1, 2017
7bd40cf
Fix git repo paths in package.json
jbovenschen Jun 2, 2017
8d4f74b
Get rid of extra span
zinserjan Jun 6, 2017
ea9ac1a
Prepare for release
ndelangen Jul 18, 2017
f3a8e48
Fixed typos in README.md
gsimone Jul 18, 2017
6fdc4e3
RENAME package & SYNC versions with monorepo && CHANGE readme
ndelangen Nov 11, 2017
986e552
FIX versions & dependencies for addon-a11y
ndelangen Nov 11, 2017
607f37d
FIX incorrect package names in readme
ndelangen Nov 11, 2017
1561f54
Merge branch 'master' into add-addon-a11y
ndelangen Nov 11, 2017
90f1711
DELETE unnecessary files
ndelangen Nov 11, 2017
88a8f00
Linting
ndelangen Nov 11, 2017
56d13ef
Remove most devDependencies
ndelangen Nov 11, 2017
90e8857
lockfile
ndelangen Nov 11, 2017
5792e09
Linting
ndelangen Nov 11, 2017
c3cfd7b
ADD story for addon-a11y to cra-kitchen-sink
ndelangen Nov 11, 2017
3bf698c
Linting
ndelangen Nov 13, 2017
862d4cf
ADD snapshots for new stories
ndelangen Nov 13, 2017
56c14a2
Merge branch 'master' into add-addon-a11y
ndelangen Nov 13, 2017
5ec50a8
FIX fonts (from lib/components)
ndelangen Nov 13, 2017
966c605
IMPROVE tabs visually
ndelangen Nov 13, 2017
857d84d
CHANGE simplify addon namespace
ndelangen Nov 13, 2017
0f30fc9
FIX lockfile
ndelangen Nov 13, 2017
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions addons/a11y/.storybook/addons.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
import '../register';
47 changes: 47 additions & 0 deletions addons/a11y/.storybook/components/Button/component.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
import React from 'react';
import PropTypes from 'prop-types';

const styles = {
button: {
padding: '12px 6px',
fontSize: '12px',
lineHeight: '16px',
borderRadius: '5px',
},
ok: {
backgroundColor: '#028402',
color: '#ffffff',
},
wrong: {
color: '#ffffff',
backgroundColor: '#4caf50',
}
}

function Button({ label, content, disabled, contrast }) {
return (
<button
style={{
...styles.button,
...styles[contrast],
}}
disabled={disabled}
>
{ content }
</button>
)
}

Button.propTypes = {
label: PropTypes.string,
content: PropTypes.string,
disabled: PropTypes.bool,
contrast: PropTypes.oneOf(['ok', 'wrong'])
};

Button.defaultProps = {
disabled: false,
contrast: 'ok',
};

export default Button;
34 changes: 34 additions & 0 deletions addons/a11y/.storybook/components/Button/stories.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
import React from 'react';
import { storiesOf } from '@storybook/react';

import { checkA11y } from './../../../src';

import Button from './component';

import Faker from 'faker';

const text = Faker.lorem.words();

storiesOf('<Button />', module)
.addDecorator(checkA11y)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these a11y stories should be moved over to CRA so we can test them together.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added, will leave the old storybook, because might copy over some more stories later.

.add('Default', () => (
<Button />
))
.add('Content', () => (
<Button content={text} />
))
.add('Label', () => (
<Button label={text} />
))
.add('Disabled', () => (
<Button
disabled
content={text}
/>
))
.add('Invalid contrast', () => (
<Button
contrast="wrong"
content={Faker.lorem.words()}
/>
));
22 changes: 22 additions & 0 deletions addons/a11y/.storybook/components/Form/components/Input.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import React from 'react';
import PropTypes from 'prop-types';

function Input({ id, value, type, placeholder }) {
return (
<input
id={id}
value={value}
placeholder={placeholder}
type={type}
/>
);
}

Input.propTypes = {
type: PropTypes.oneOf(['text', 'password']),
id: PropTypes.string,
value: PropTypes.string,
placeholder: PropTypes.string,
}

export default Input;
26 changes: 26 additions & 0 deletions addons/a11y/.storybook/components/Form/components/Label.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
import React from 'react';
import PropTypes from 'prop-types';

const styles = {
label: {
padding: '0 6px',
},
}

function Label({ id, content }) {
return (
<label
style={styles.label}
htmlFor={id}
>
{ content }
</label>
)
}

Label.propTypes = {
content: PropTypes.string,
id: PropTypes.string,
};

export default Label;
21 changes: 21 additions & 0 deletions addons/a11y/.storybook/components/Form/components/Row.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import React from 'react';
import PropTypes from 'prop-types';

import Label from './Label';
import Input from './Input';

function Row({ label, input }) {
return (
<div>
{label}
{input}
</div>
);
}

Row.propTypes = {
label: PropTypes.instanceOf(Label),
input: PropTypes.instanceOf(Input),
}

export default Row;
9 changes: 9 additions & 0 deletions addons/a11y/.storybook/components/Form/components/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import Input from './Input';
import Label from './Label';
import Row from './Row';

export {
Input,
Label,
Row,
};
36 changes: 36 additions & 0 deletions addons/a11y/.storybook/components/Form/stories.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
import React from 'react';

import * as Form from './components';

import { storiesOf } from '@storybook/react';
import { checkA11y } from './../../../src';

import Faker from 'faker';

const label = Faker.lorem.word();
const placeholder = Faker.lorem.word();

storiesOf('<Form />', module)
.addDecorator(checkA11y)
.add('Without Label', () => (
<Form.Row
input={<Form.Input />}
/>
))
.add ('With label', () => (
<Form.Row
label={<Form.Label
content={label}
id="1"
/>}
input={<Form.Input id="1" />}
/>
))
.add ('With placeholder', () => (
<Form.Row
input={<Form.Input
id="1"
placeholder={placeholder}
/>}
/>
))
20 changes: 20 additions & 0 deletions addons/a11y/.storybook/components/Image/component.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import React from 'react';
import PropTypes from 'prop-types';

function Image({ src, alt, presentation }) {
return (
<img
src={src}
alt={alt}
role={presentation && 'presentation'}
/>
);
}

Image.propTypes = {
src: PropTypes.string.isRequired,
alt: PropTypes.string,
presentation: PropTypes.bool,
};

export default Image;
29 changes: 29 additions & 0 deletions addons/a11y/.storybook/components/Image/stories.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import React from 'react';
import { storiesOf } from '@storybook/react';

import { checkA11y } from './../../../src';

import Image from './component';

import Faker from 'faker';

const image = Faker.image.animals();
const alt = Faker.lorem.words();

storiesOf('<Image />', module)
.addDecorator(checkA11y)
.add('Without alt', () => (
<Image src={image} />
))
.add('With alt', () => (
<Image
src={image}
alt={alt}
/>
))
.add('Presentation', () => (
<Image
presentation
src={image}
/>
));
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import React, { cloneElement } from 'react';
import PropTypes from 'prop-types';

const headings = {
1: (<h1 />),
2: (<h2 />),
3: (<h3 />),
4: (<h4 />),
};

function Heading({ level, children }) {
return cloneElement(headings[level], {}, children)
}

Heading.propTypes = {
level: PropTypes.oneOf([1, 2, 3, 4]),
children: PropTypes.any,
};

Heading.defaultProps = {
level: 1,
};

export default Heading;
17 changes: 17 additions & 0 deletions addons/a11y/.storybook/components/Typography/components/Link.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import React from 'react';
import PropTypes from 'prop-types';

function Link({ href, content }) {
return (
<a href={href}>
{ content }
</a>
);
}

Link.propTypes = {
href: PropTypes.string,
content: PropTypes.string,
};

export default Link;
16 changes: 16 additions & 0 deletions addons/a11y/.storybook/components/Typography/components/Text.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import React from 'react';
import PropTypes from 'prop-types';

function Text({ children }) {
return (
<p>
{children}
</p>
);
}

Text.propTypes = {
children: PropTypes.any,
};

export default Text;
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import Heading from './Heading';
import Link from './Link';
import Text from './Text';

export {
Heading,
Link,
Text,
};
41 changes: 41 additions & 0 deletions addons/a11y/.storybook/components/Typography/stories.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
import React from 'react';
import { storiesOf } from '@storybook/react';

import { checkA11y } from './../../../src';

import * as Typography from './components';

import Faker from 'faker';

const href = "javascript:void 0";

storiesOf('<Typography />', module)
.addDecorator(checkA11y)
.add('Correct', () => (
<div>
<Typography.Heading level={1}>
{Faker.lorem.sentence()}
</Typography.Heading>

<Typography.Text>
{Faker.lorem.paragraph()}
</Typography.Text>

<Typography.Link
content={`${Faker.lorem.words(4)}...`}
href={href}
/>
</div>
))
.add('Empty Heading', () => (
<Typography.Heading level={2} />
))
.add('Empty Paragraph', () => (
<Typography.Text />
))
.add('Empty Link', () => (
<Typography.Link href={href} />
))
.add('Link without href', () => (
<Typography.Link content={`${Faker.lorem.words(4)}...`} />
));
9 changes: 9 additions & 0 deletions addons/a11y/.storybook/config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import * as storybook from '@storybook/react';

const req = require.context('./components/', true, /stories\.js$/)

const loadStories = () =>
req.keys().forEach(req);


storybook.configure(loadStories, module)
Loading