Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Change Button stories layout for React starter templates #22951

Merged
merged 6 commits into from
Jun 14, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jun 7, 2023

Relates to #22784

What I did

  • Add layout: 'centered' to button stories
  • Add Typescript 4.9 templates to @storybook/nextjs

How to test

  1. Run a sandbox for a react template, e.g. yarn task --task sandbox --start-from auto --template react-vite/default-ts
  2. Check the example stories

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added ci: do not merge cli ci:daily Run the CI jobs that normally run in the daily job. labels Jun 7, 2023
@yannbf yannbf requested a review from a team as a code owner June 7, 2023 08:29
@yannbf yannbf self-assigned this Jun 12, 2023
@yannbf yannbf added the maintenance User-facing maintenance tasks label Jun 13, 2023
@yannbf
Copy link
Member Author

yannbf commented Jun 14, 2023

Chromatic timed out for Preact, I'm merging this PR as it's safe to do so!

@yannbf yannbf merged commit 9eb5125 into next Jun 14, 2023
@yannbf yannbf deleted the feat/improve-react-cli-templates branch June 14, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:daily Run the CI jobs that normally run in the daily job. cli maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants