Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: Pin file-system-cache to 2.3.0 #23221

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Dependencies: Pin file-system-cache to 2.3.0 #23221

merged 1 commit into from
Jun 27, 2023

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Jun 27, 2023

Closes #23220

What I did

Pinned the dependency file-system-cache to v2.3.0 to avoid the failing v.2.4.0 as reported in the issue.

This is the result of yarn why file-system-cache in code:

├─ @storybook/core-common@workspace:lib/core-common
│  └─ file-system-cache@npm:2.3.0 (via npm:2.3.0)
│
└─ @storybook/types@workspace:lib/types
   └─ file-system-cache@npm:2.3.0 (via npm:2.3.0)

How to test

Must be tested in a case-sensitive operating system like Linux - not MacOS or Windows.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@JReinhold JReinhold self-assigned this Jun 27, 2023
@JReinhold JReinhold added dependencies patch:yes Bugfix & documentation PR that need to be picked to main branch ci:daily Run the CI jobs that normally run in the daily job. labels Jun 27, 2023
@JReinhold JReinhold marked this pull request as ready for review June 27, 2023 00:17
@shilman shilman merged commit 54142ad into next Jun 27, 2023
@shilman shilman deleted the fix-23200 branch June 27, 2023 02:46
shilman added a commit that referenced this pull request Jun 27, 2023
Dependencies: Pin `file-system-cache` to 2.3.0
(cherry picked from commit 54142ad)
@JReinhold JReinhold added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 27, 2023
@tremby
Copy link

tremby commented Jun 28, 2023

The dependency author has fixed the issue so this could potentially be unpinned again now.

@seriouz
Copy link
Contributor

seriouz commented Jun 29, 2023

Yes please use the new version 2.4.1 our pipeline broke with 2.4.0... But 2.4.1 is working again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:daily Run the CI jobs that normally run in the daily job. dependencies patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: All npx storybook@latest ... commands fail with Error: Cannot find module './util'
4 participants