Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Tests: Fix tests on Windows #23305

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Unit Tests: Fix tests on Windows #23305

merged 1 commit into from
Jul 4, 2023

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Jul 4, 2023 •
edited
Loading

Closes N/A

What I did

Fix tests on Windows

How to test

not required, since Unit tests will fail if the change is not correct

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@valentinpalkovic valentinpalkovic self-assigned this Jul 4, 2023
@valentinpalkovic valentinpalkovic added the maintenance User-facing maintenance tasks label Jul 4, 2023
@valentinpalkovic valentinpalkovic changed the title Fix tests on Windows Unit Tests: Fix tests on Windows Jul 4, 2023
@valentinpalkovic valentinpalkovic added build Internal-facing build tooling & test updates and removed maintenance User-facing maintenance tasks labels Jul 4, 2023
@valentinpalkovic valentinpalkovic merged commit 7b79548 into next Jul 4, 2023
@valentinpalkovic valentinpalkovic deleted the valentin/fix-windows-tests branch July 4, 2023 14:37
@github-actions github-actions bot mentioned this pull request Jul 4, 2023
Merged
7 tasks
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jul 4, 2023
JReinhold pushed a commit that referenced this pull request Jul 4, 2023
@valentinpalkovic @github-actions
Merge pull request #23305 from storybookjs/valentin/fix-windows-tests
332fe2d 
Unit Tests: Fix tests on Windows

(cherry picked from commit 7b79548)
@github-actions github-actions bot mentioned this pull request Jul 4, 2023
Merged
18 tasks
JReinhold pushed a commit that referenced this pull request Jul 4, 2023
@valentinpalkovic @github-actions
Merge pull request #23305 from storybookjs/valentin/fix-windows-tests
d015fb3 
Unit Tests: Fix tests on Windows

(cherry picked from commit 7b79548)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 5, 2023
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman Awaiting requested review from shilman

Assignees

@valentinpalkovic valentinpalkovic

Labels
build Internal-facing build tooling & test updates patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentinpalkovic @shilman