Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Addon-docs: Add opt-in table of contents"" #23334

Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Jul 6, 2023

Reverts #23333

Try to add it back but run full merged CI this time

@shilman shilman added the ci:merged Run the CI jobs that normally run when merged. label Jul 6, 2023
@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
tocbot 4.21.0 network, environment +0 807 kB tscanlin

@shilman shilman marked this pull request as draft July 6, 2023 09:59
@shilman shilman marked this pull request as ready for review July 6, 2023 17:40
@shilman shilman added the build Internal-facing build tooling & test updates label Jul 6, 2023
@shilman shilman merged commit 51d6e46 into next Jul 6, 2023
@shilman shilman deleted the revert-23333-revert-23142-shilman/toc-proof-of-concept branch July 6, 2023 18:02
@github-actions github-actions bot mentioned this pull request Jul 6, 2023
11 tasks
@chakAs3
Copy link
Contributor

chakAs3 commented Jul 7, 2023

@shilman this breaks ca-default-js

ERR!         /Users/chakir/devs/sb/storybook/sandbox/cra-default-js/template-stories/addons/docs/toc/basic.stories.mjs doesn't exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:merged Run the CI jobs that normally run when merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants