Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Show the story status in the search results #23441

Merged
merged 9 commits into from
Jul 18, 2023

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jul 13, 2023

Follow-up from: #23342 and #22890

What I did

I added the colored icon to the search-results similar to the Tree-items in the Sidebar component.
I added a story for increased coverage

How to test

The newly added story should demonstrate the behavior.
If you want to reproduce for yourself, please check the steps to test on this PR: #23342

And then use the search feature in the sidebar

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@MichaelArestad
Copy link
Contributor

Looking at the UI Review results, there are dozens of stories being added. I'm guessing they have nothing to do with this PR. Is that correct?

@ndelangen ndelangen merged commit afdc58a into release/7.2 Jul 18, 2023
@ndelangen ndelangen deleted the norbert/status-in-search-item branch July 18, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants