Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: fix readme storyshots link #23467

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

kawokas
Copy link
Contributor

@kawokas kawokas commented Jul 16, 2023

What I did

The link to storyshots in the README was broken. I have fixed this.

How to test

README link to storyshots jumps correctly

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@jonniebigodes jonniebigodes self-assigned this Jul 16, 2023
@jonniebigodes jonniebigodes added documentation ci:normal patch:yes Bugfix & documentation PR that need to be picked to main branch and removed ci:normal labels Jul 16, 2023
@jonniebigodes
Copy link
Contributor

@kawokas thanks for taking the time to put together this pull request and catch that small but rather important issue in the documentation. Appreciate it 🙏 ! I've checked and all is good on my end. I'll merge it once the checklist clears.

Hope you have a fantastic day.

Stay safe

@kawokas
Copy link
Contributor Author

kawokas commented Jul 20, 2023

@jonniebigodes
Thank you for checking! 🙇‍♂️

I changed the Workflow permissions setting to read and write permission, so I think Danger JS CI will pass if you re-run it.
If there is anything else missing, please let me know.

thank you !

@jonniebigodes
Copy link
Contributor

@kawokas, no need to thank whatsoever; it was my pleasure, and don't worry about the Danger JS issue. We're aware of it and we'll soon have it addressed to accommodate pull requests similar to this one.

@jonniebigodes jonniebigodes merged commit f6ee55b into storybookjs:next Jul 20, 2023
storybook-bot pushed a commit that referenced this pull request Jul 20, 2023
Docs: fix readme storyshots link
(cherry picked from commit f6ee55b)
@github-actions github-actions bot mentioned this pull request Jul 20, 2023
14 tasks
storybook-bot pushed a commit that referenced this pull request Jul 21, 2023
Docs: fix readme storyshots link
(cherry picked from commit f6ee55b)
storybook-bot pushed a commit that referenced this pull request Jul 21, 2023
Docs: fix readme storyshots link
(cherry picked from commit f6ee55b)
storybook-bot pushed a commit that referenced this pull request Jul 21, 2023
Docs: fix readme storyshots link
(cherry picked from commit f6ee55b)
storybook-bot pushed a commit that referenced this pull request Jul 21, 2023
Docs: fix readme storyshots link
(cherry picked from commit f6ee55b)
storybook-bot pushed a commit that referenced this pull request Jul 21, 2023
Docs: fix readme storyshots link
(cherry picked from commit f6ee55b)
storybook-bot pushed a commit that referenced this pull request Jul 21, 2023
Docs: fix readme storyshots link
(cherry picked from commit f6ee55b)
storybook-bot pushed a commit that referenced this pull request Jul 24, 2023
Docs: fix readme storyshots link
(cherry picked from commit f6ee55b)
storybook-bot pushed a commit that referenced this pull request Jul 24, 2023
Docs: fix readme storyshots link
(cherry picked from commit f6ee55b)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants