-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: fix readme storyshots link #23467
Docs: fix readme storyshots link #23467
Conversation
@kawokas thanks for taking the time to put together this pull request and catch that small but rather important issue in the documentation. Appreciate it 🙏 ! I've checked and all is good on my end. I'll merge it once the checklist clears. Hope you have a fantastic day. Stay safe |
@jonniebigodes I changed the Workflow permissions setting to read and write permission, so I think Danger JS CI will pass if you re-run it. thank you ! |
@kawokas, no need to thank whatsoever; it was my pleasure, and don't worry about the Danger JS issue. We're aware of it and we'll soon have it addressed to accommodate pull requests similar to this one. |
Docs: fix readme storyshots link (cherry picked from commit f6ee55b)
Docs: fix readme storyshots link (cherry picked from commit f6ee55b)
Docs: fix readme storyshots link (cherry picked from commit f6ee55b)
Docs: fix readme storyshots link (cherry picked from commit f6ee55b)
Docs: fix readme storyshots link (cherry picked from commit f6ee55b)
Docs: fix readme storyshots link (cherry picked from commit f6ee55b)
Docs: fix readme storyshots link (cherry picked from commit f6ee55b)
Docs: fix readme storyshots link (cherry picked from commit f6ee55b)
Docs: fix readme storyshots link (cherry picked from commit f6ee55b)
What I did
The link to storyshots in the README was broken. I have fixed this.
How to test
README link to storyshots jumps correctly
Checklist
MIGRATION.MD
Maintainers
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]