Update controls.md #23485
Merged
Update controls.md #23485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proposed changes eliminate the misleading assumption that this functionality can be used for control types other than `color` and `date`
jonniebigodes
added
documentation
patch:yes
kasperpeulen
removed
the
patch:yes
jonniebigodes
requested review from
kylegach and
jonniebigodes
as code owners
jonniebigodes
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
@DiamondeX first and foremost, sorry for taking too long to review this pull request, but we've been quite busy here at Storybook. And with that out of the way, thanks for taking the time to put together this pull request and help us improve the documentation. Appreciate it 🙏 ! I've checked and I'm ok with the change. I'l get this merged once the checklist clears.
Hope you have a fantastic day.
Stay safe
jonniebigodes
added
ci:docs
|
This has already been patched back with the latest changes in the |
This was referenced Nov 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed changes eliminate the misleading assumption that this functionality can be used for control types other than
coloranddateCloses #
What I did
How to test
Checklist
MIGRATION.MD
Maintainers
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]